just format formats entire solution
#3174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jar-stripe
requested review from
prathmesh-stripe
and removed request for
a team
jar-stripe
requested review from
xavdid-stripe
and removed request for
prathmesh-stripe
xavdid-stripe
approved these changes
Sep 19, 2025
Member
xavdid-stripe
left a comment
xavdid-stripe
left a comment
There was a problem hiding this comment.
Is it slower?
😭😭😭
Like you're right, it's fine, but it's just so slow already 🙈
helenye-stripe
pushed a commit
that referenced
this pull request
Sep 23, 2025
* Add private-preview branch to CI workflow triggers 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> *⚠️ Build SDK w/ V2 OpenAPI spec (#3167) * generate w/ v2 openapi spec * move deleted object path * Adds public BaseUrl to RawRequestOptions (#3170) renames internal BaseUrl in RequestOptions to InternalBaseUrl adds public BaseUrl to RawRequestOptions - it delegates to InternalBaseUrl for safety * Update generated code (#3172) * Update generated code for v1955 and 2025-09-30.clover * Update generated code for v1968 and 2025-09-30.clover --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> * `just format` formats entire solution (#3174) * Adds ability to specify file name and type when calling FileService.Create (#3171) * Update generated code for 9de7288a5c444f47d15545549303c3de4c226c71 and 2025-09-30.clover --------- Co-authored-by: Michael Broshi <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: David Brownman <[email protected]> Co-authored-by: jar-stripe <[email protected]> Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
This was referenced Oct 2, 2025
This was referenced Oct 23, 2025
This was referenced Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
just formatis run by our code generator after generating code. I noticed it was only formatting code in Stripe.net and not in StripeTests (which contains generated content). This PR changesjust formatto use the .sln file which should cover all projects in the repo.Is it slower?
Marginally, but I think its ok.
Before:
After:
What?